Call SVGElement::WillRecalcStyle() with Svg2Cascade enabled#58333
Merged
chromium-wpt-export-bot merged 1 commit intomasterfrom Mar 7, 2026
Merged
Call SVGElement::WillRecalcStyle() with Svg2Cascade enabled#58333chromium-wpt-export-bot merged 1 commit intomasterfrom
chromium-wpt-export-bot merged 1 commit intomasterfrom
Conversation
Collaborator
Author
|
Close this PR because the Chromium CL does not have exportable changes. |
Collaborator
Author
|
Close this PR because the Chromium CL does not have exportable changes. |
SetHasCustomStyleCallbacks() was skipped for Svg2CascadeEnabled() since CustomStyleForLayoutObject was no longer needed, but WillRecalcStyle() also requires that flag to be set for invocation. Fixes a SMIL animation issue for underlying value changes. Bug: 490288680 Change-Id: I3eda165fda101fa8130f44a275c5dd40ed3f1e16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7643050 Reviewed-by: Fredrik Söderquist <fs@opera.com> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1595367}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-7643050
branch
from
121427e to
8df5c7e
Compare
wpt-pr-bot
approved these changes
Mar 7, 2026
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SetHasCustomStyleCallbacks() was skipped for Svg2CascadeEnabled() since
CustomStyleForLayoutObject was no longer needed, but WillRecalcStyle()
also requires that flag to be set for invocation.
Fixes a SMIL animation issue for underlying value changes.
Bug: 490288680
Change-Id: I3eda165fda101fa8130f44a275c5dd40ed3f1e16
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7643050
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1595367}