Call verifySelectedSnapTarget for single axis#59386
Open
denvercoder21 wants to merge 1 commit into
Open
Conversation
verifySelectedSnapTarget only handles passing a single axis as the axis parameter to it gracefully. runScrollSnapSelectionVerificationTest might call it with axis=="both" which could yield wrong results. This changes calls verifySelectedSnapTarget twice (once for x, once for y) in case axis=="both".
denvercoder21
force-pushed
the
call-verifySelectedSnapTarget-with-single-axis
branch
from
92ee6ef to
b70c345
Compare
Contributor
Author
|
@tabatkins I'm new to this. Is there something I should do or check? CI run seems to look okay, I'm unsure about the skipped Safari/macOS jobs. |
Contributor
|
Ah, sorry, I'm gonna move this to @flackr for review. I'm not immediately familiar with the intended JS behavior here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
verifySelectedSnapTargetonly handles passing a single axis as the axis parameter to it gracefully.runScrollSnapSelectionVerificationTestmight call it withaxis=="both"which could yield wrong results.This changes calls
verifySelectedSnapTargettwice (once for x, once for y) in caseaxis=="both".