Remove .tentative from setHTMLUnsafe-runScripts test#60234
Open
noamr wants to merge 3 commits into
Open
Conversation
5 tasks
annevk
reviewed
May 28, 2026
Member
annevk
left a comment
There was a problem hiding this comment.
I think we need more coverage. E.g.,
- unsafe + sanitizer that removes the script element.
- multiple script and style elements with the script elements trying to observe the order in which state gets initialized and things are run (cc @domfarolino)
We should also add a test that ensures Document.parseHTMLUnsafe and Element.prototype.setHTML don't look at this member (throw if the binding layer attempts to get it).
@hsivonen might also have some ideas for this, perhaps?
Contributor
Author
Added tests to that effect. Happy to add more coverage that people think would be useful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See whatwg/html#12495