Skip to content

Allow relative scrolls in unrelated-gesture-scroll-during-snap.html #60235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
denvercoder21 wants to merge 1 commit into
base: master
Choose a base branch
from
+13 −4
Open

Allow relative scrolls in unrelated-gesture-scroll-during-snap.html #60235

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions css/css-scroll-snap/unrelated-gesture-scroll-during-snap.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,13 @@
];
let last_scroll_top = snapcontainer.scrollTop;
async function scroll_listener() {
// If we are scrolling back to 0, we are snapping.
if (snapcontainer.scrollTop < last_scroll_top) {
// If scrollTop is decreasing we are snapping back (absolute-scroll
// case).
// If scrollTop is increasing past the initial scroll amount we are
// snapping forward (relative-scroll case).
if (snapcontainer.scrollTop < last_scroll_top ||
(snapcontainer.scrollTop > last_scroll_top &&
snapcontainer.scrollTop > snap_scroll_amt)) {
snapcontainer.removeEventListener("scroll", scroll_listener);
await new test_driver.Actions().scroll(0, 0, 0, inputs.scroll_amt,
{ origin: other_container }).send();
Expand All @@ -101,8 +106,12 @@
.send();

await Promise.all(scrollend_promises);
assert_equals(snapcontainer.scrollTop, 0,
"snapcontainer snaps back to 0");
const second_snap_offset =
snapcontainer.querySelectorAll(".snaparea")[1].offsetTop;
assert_true(snapcontainer.scrollTop === 0 ||
snapcontainer.scrollTop === second_snap_offset,
"snapcontainer snaps to a snap point (0 or " +
second_snap_offset + "), got " + snapcontainer.scrollTop);
assert_equals(other_container.scrollTop, expectations.expectedScrollTop,
`${other_container.id} is at expected scroll offset.`);
}
Expand Down
Loading