Skip to content

TrustedParserOptions: return a new sanitizer in each call #61339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chromium-wpt-export-bot merged 1 commit into from
Jul 16, 2026
Merged

TrustedParserOptions: return a new sanitizer in each call #61339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 4 additions & 13 deletions domparsing/tentative/stream-html-with-trusted-types-pass-trusted.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,20 +33,14 @@
}

const methods = [
"streamHTML",
"streamHTMLUnsafe",
"streamAppendHTML",
"streamAppendHTMLUnsafe",
"streamPrependHTML",
"streamPrependHTMLUnsafe",
"streamBeforeHTML",
"streamBeforeHTMLUnsafe",
"streamAfterHTML",
"streamAfterHTMLUnsafe",
];

for (const method of methods) {
const safe = !method.endsWith("Unsafe");
promise_test(
async (t) => {
t.add_cleanup(cleanup);
Expand All @@ -67,13 +61,10 @@
window.did_run = false;
await writer.write("<script>window.did_run = true;<" + "/script>");
await writer.close();
assert_equals(
container.querySelectorAll("script").length,
safe ? 0 : 1,
);
assert_equals(window.did_run, !safe);
assert_equals(container.querySelectorAll("script").length, 1);
assert_equals(window.did_run, true);
},
`A given TrustedParserOptions can${safe ? " not" : ""} override default policy's runScript/safety for ${method}`,
`A given TrustedParserOptions can override default policy's runScript/safety for ${method}`,
);
}

Expand All @@ -94,7 +85,7 @@
const writer = d[method](trusted_options).getWriter();
window.did_run = false;
await writer.write(
"<div id=allowed><span id=forbidden></span<</div>",
"<div id=allowed><span id=forbidden></span></div>",
);
await writer.close();
assert_equals(
Expand Down
17 changes: 9 additions & 8 deletions sanitizer-api/sethtml-with-trustedtypes-immutable.tentative.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,19 +91,20 @@
assert_true(callback_sanitizer instanceof Sanitizer, "callback should receive a Sanitizer object");

// 2. Check that the returned TrustedParserOptions contains a Sanitizer object.
assert_true(options.sanitizer instanceof Sanitizer, "TrustedParserOptions.sanitizer should return a Sanitizer");
assert_true(options.sanitizer() instanceof Sanitizer, "TrustedParserOptions.sanitizer() should return a Sanitizer");
assert_not_equals(options.sanitizer(), options.sanitizer(), "calling sanitizer() twice should return different objects");

// 3. Mutating the Sanitizer returned by the getter does not affect sanitizing.
// 3. Mutating the Sanitizer returned by the method does not affect sanitizing.
// The config had removeElements: ["span"]. Let's try to mutate the returned sanitizer to also remove "div".
options.sanitizer.removeElement("div");
options.sanitizer().removeElement("div");

const d = document.createElement("div");
document.querySelector("#container").appendChild(d);
t.add_cleanup(() => d.remove());

d.setHTMLUnsafe("<div>Allowed<span>Forbidden</span></div>", options);

// "div" should NOT be removed (because mutation on options.sanitizer has no effect on the clone used for parsing).
// "div" should NOT be removed (because mutation on options.sanitizer() has no effect on the clone used for parsing).
assert_not_equals(d.querySelector("div"), null, "div should not be removed by mutated sanitizer");
// "span" should still be removed (because the original config specified removeElements: ["span"]).
assert_equals(d.querySelector("span"), null, "span should be removed by original sanitizer configuration");
Expand All @@ -123,9 +124,9 @@
const options = policy.createParserOptions({ sanitizer: s });
assert_true(callback_sanitizer instanceof Sanitizer, "callback should receive a Sanitizer object");
assert_not_equals(callback_sanitizer, s, "callback sanitizer should be a clone, not the original");
assert_true(options.sanitizer instanceof Sanitizer, "TrustedParserOptions.sanitizer should return a Sanitizer");
assert_not_equals(options.sanitizer, s, "getter sanitizer should be a clone, not the original");
assert_equals(options.sanitizer, options.sanitizer, "SameObject: getter should return the same object reference");
assert_true(options.sanitizer() instanceof Sanitizer, "TrustedParserOptions.sanitizer() should return a Sanitizer");
assert_not_equals(options.sanitizer(), s, "method sanitizer() should return a clone, not the original");
assert_not_equals(options.sanitizer(), options.sanitizer(), "method sanitizer() should return different object references in every call");
}, "TrustedParserOptions sanitizer clone testing with Sanitizer object input");

test((t) => {
Expand All @@ -140,7 +141,7 @@

const options = policy.createParserOptions({ sanitizer: "default" });
assert_true(callback_sanitizer instanceof Sanitizer, "callback should receive a Sanitizer object when preset is passed");
assert_true(options.sanitizer instanceof Sanitizer, "TrustedParserOptions.sanitizer should return a Sanitizer when preset is passed");
assert_true(options.sanitizer() instanceof Sanitizer, "TrustedParserOptions.sanitizer() should return a Sanitizer when preset is passed");
}, "TrustedParserOptions sanitizer clone testing with Preset string input");
</script>
</body>
Expand Down
Loading