Remove square brackets from getInputHTML#2
Open
mylesthedev wants to merge 1 commit intowebdna:masterfrom
Open
Conversation
This should be left up to the twig code as it's much easier to add square brackets like this in twig than it is to remove them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It might pay to leave it up to the twig being passed through to have the square brackets.
It's much more difficult to remove [] in twig than it is to add them e.g. json_encode.
For example:
{% set myArray = [] %} {% for item in items %} {% set myArray = myArray|merge([{ 'label': item.label, 'value': item.id }]) %} {% endfor %} {{ myArray | json_encode() | raw }}