fix(calling): new method getDevices added#4684
fix(calling): new method getDevices added#4684Kesari3008 wants to merge 5 commits intowebex:nextfrom
Conversation
| return activeMobiusUrl; | ||
| } | ||
|
|
||
| if (this.primaryMobiusUris.length) { |
There was a problem hiding this comment.
@Kesari3008 why do do these check , from what i read we have to get active mobius from all of the mobius server then do a delete
There was a problem hiding this comment.
Updated the approach now
| /** | ||
| * Fetches the list of devices for a given user from Mobius. | ||
| */ | ||
| public async getDevices(userId: string): Promise<DeviceType[]> { |
There was a problem hiding this comment.
Do we need this param?
why not this.webex.internal.device.userId ?
|
Now If we have to de-register user/developer need to run through this list(DeviceType[]) and call de-register. Why not give this as a simple one more method deRegisterAllDevices() ? just thinking it out loud. |
This is somehting we can consider for future. At the moment, multiple devices are not supported for one user. But registration is also somehting not implemented so allowing to deregiter for multiple devices would be something not required |
arun3528
left a comment
arun3528
left a comment
There was a problem hiding this comment.
@Kesari3008 @rsarika i am ok with this approach of saving the the url in local storage and then cleaning it up .
but if its active why not reclaim it , why do we have to delete it
my idea of the whole cleanup was that the user does not know which mobius they are active on so they wil have to do feat all then see if there is a active one available then do a delete on that , when we do automation local storage is not shared across PRs
3 participants
COMPLETES #https://jira-eng-sjc12.cisco.com/jira/browse/CAI-7541
This pull request addresses
Needed to fetch device list for a user if needed to be cleared during reload or refreshes.
by making the following changes
Added new API: getDevices() under CallingClient module to fetch list of registered devices for a user. It helps deleting registrations if not required or handle duplicate registration cases more gracefully.
Change Type
The following scenarios were tested
Using SDK Kitchen Sink App tested it.
Network Logs are attached in the Jira
The GAI Coding Policy And Copyright Annotation Best Practices
I certified that
Make sure to have followed the contributing guidelines before submitting.