Skip to content

feat(e2ee): emit meeting event when srtp cipher is changed#4712

Merged
jor-row merged 8 commits intowebex:nextfrom
jor-row:feat/emit-event-srtpcipher
Apr 28, 2026
Merged

feat(e2ee): emit meeting event when srtp cipher is changed#4712
jor-row merged 8 commits intowebex:nextfrom
jor-row:feat/emit-event-srtpcipher

Conversation

@jor-row
Copy link
Copy Markdown
Contributor

@jor-row jor-row commented Feb 13, 2026

COMPLETES SPARK-783803

This pull request addresses

Based on the new event sent from internal-media-core which was added in https://sqbu-github.cisco.com/WebExSquared/webrtc-media-core/pull/365 , grab the srtpCipher from the transport stat and forward that on in an event called MEETING_SRTP_CIPHER_UPDATED. This new event will be listened to in Cantina to update redux. The cipher could theoretically change in the middle of a meeting, which is why the event bus was used.

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios were tested

< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >

The GAI Coding Policy And Copyright Annotation Best Practices

  • GAI was not used (or, no additional notation is required)
  • Code was generated entirely by GAI
  • GAI was used to create a draft that was subsequently customized or modified
  • Coder created a draft manually that was non-substantively modified by GAI (e.g., refactoring was performed by GAI on manually written code)
  • Tool used for AI assistance (GitHub Copilot / Other - specify)
    • Github Copilot
    • Other - Please Specify
  • This PR is related to
    • Feature
    • Defect fix
    • Tech Debt
    • Automation

I certified that

  • I have read and followed contributing guidelines
  • I discussed changes with code owners prior to submitting this pull request
  • I have not skipped any automated checks
  • All existing and new tests passed
  • I have updated the documentation accordingly

Make sure to have followed the contributing guidelines before submitting.

@jor-row jor-row added bug-fix PRs that fix bugs validated If the pull request is validated for automation. feature and removed bug-fix PRs that fix bugs labels Feb 13, 2026
Comment thread packages/@webex/plugin-meetings/src/meeting/index.ts Outdated
@jor-row jor-row marked this pull request as ready for review April 27, 2026 13:54
@jor-row jor-row requested review from a team as code owners April 27, 2026 13:54
@aws-amplify-us-east-2
Copy link
Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-4712.d3m3l2kee0btzx.amplifyapp.com

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 093fd554ec

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread packages/@webex/plugin-meetings/test/unit/spec/meeting/index.js Outdated
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d7d8ab19c7

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread packages/@webex/plugin-meetings/src/meeting/index.ts
Copy link
Copy Markdown
Collaborator

@chrisadubois chrisadubois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only thing I'd say is we might want to add a readonly getter for the srtp cipher value, else lgtm

@jor-row jor-row enabled auto-merge (squash) April 28, 2026 13:55
@jor-row jor-row merged commit e362196 into webex:next Apr 28, 2026
12 checks passed
@jor-row jor-row deleted the feat/emit-event-srtpcipher branch April 28, 2026 14:07
@github-actions
Copy link
Copy Markdown

🎉 Your changes are now available!
Released in: v3.12.0-next.54
📖 View full changelog →
Packages Updated Version
webex 3.12.0-next.54
@webex/plugin-meetings 3.12.0-next.42

Thank you for your contribution!
🤖 This is an automated message. For queries, please contact support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature validated If the pull request is validated for automation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants