feat(e2ee): emit meeting event when srtp cipher is changed#4712
feat(e2ee): emit meeting event when srtp cipher is changed#4712jor-row merged 8 commits intowebex:nextfrom
Conversation
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 093fd554ec
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d7d8ab19c7
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
chrisadubois
left a comment
There was a problem hiding this comment.
Only thing I'd say is we might want to add a readonly getter for the srtp cipher value, else lgtm
Thank you for your contribution! |
COMPLETES SPARK-783803
This pull request addresses
Based on the new event sent from internal-media-core which was added in https://sqbu-github.cisco.com/WebExSquared/webrtc-media-core/pull/365 , grab the srtpCipher from the transport stat and forward that on in an event called MEETING_SRTP_CIPHER_UPDATED. This new event will be listened to in Cantina to update redux. The cipher could theoretically change in the middle of a meeting, which is why the event bus was used.
Change Type
The following scenarios were tested
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >
The GAI Coding Policy And Copyright Annotation Best Practices
I certified that
Make sure to have followed the contributing guidelines before submitting.