Use web-root specified for the core's scaffold plugin#49
Open
hussainweb wants to merge 1 commit intowebflo:masterfrom
Open
Use web-root specified for the core's scaffold plugin#49hussainweb wants to merge 1 commit intowebflo:masterfrom
hussainweb wants to merge 1 commit intowebflo:masterfrom
Conversation
Author
|
With this, we can close #33. |
Author
|
The errors are again with |
|
The travis errors only happen for PHP 5.5 like written above. Is this unrelated and do we anyway have to check PHP 5.5 anymore for future releases? As of 8fc0ece I guess the tests should be re-run`without PHP 5.5? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the new core scaffold plugin contains a setting for web-root, I think that is the most appropriate setting to determine the path. This PR updates the code to look at that setting first and then the existing approach of
installer-paths.