Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
cursor review |
|
Skipping Bugbot: Bugbot is disabled for this repository |
|
cursor review |
|
Skipping Bugbot: Bugbot is disabled for this repository |
|
cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| fi | ||
| - name: Pull Docker images | ||
| run: | | ||
| docker compose -f test/docker-compose.yml pull |
There was a problem hiding this comment.
Bug: Docker images pulled despite cache hit
The docker compose pull command runs unconditionally, even when cached images are successfully loaded. This defeats the caching mechanism's purpose by always pulling images from the registry regardless of cache hits, negating any performance benefits from the cache.
Additional Locations (1)
| done < /tmp/.docker/images_list.txt | ||
| # Combine all image tars into one compressed archive | ||
| if ls /tmp/.docker/*.tar 1> /dev/null 2>&1; then | ||
| cd /tmp/.docker && tar -czf images.tar.gz *.tar && rm -f *.tar images_list.txt && mv images.tar.gz images.tar |
There was a problem hiding this comment.
Bug: Cached images cannot be loaded correctly
The save step creates individual tar files per image, then combines them into a compressed archive using tar -czf. However, docker load expects the format produced by docker save, not a tar archive containing multiple tar files. This nested structure won't load correctly, causing the cache restoration to fail.
Additional Locations (1)
|
cursor review |
2 participants
Note
Adds Docker image caching (save/load) to integration test jobs to reduce image pull time.
tests-integration-main,tests-integration-o11):actions/cacheto store images under/tmp/.dockerkeyed bytest/docker-compose.yml.images.tar).Written by Cursor Bugbot for commit 524ec8a. Configure here.