feat: add type alias support to LSP#1
Merged
Merged
Conversation
Iterate root.TypeAliases() in buildPartialSchema() so alias types are visible to hover, completion, and go-to-definition. Update webrpc dependency to include upstream alias parser support.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TypeAliasNodetype alias for upstream parser noderoot.TypeAliases()inbuildPartialSchema()so alias types are visible to hover, completion, and go-to-definitionRelease order
Depends on webrpc v0.37.0 (webrpc/webrpc#439). Must update
go.modto pin to the release tag before merging.v0.37.0← merge and tag firstv0.28.0v0.26.0v1.1.0← this PRv0.0.2Test plan
go.modtowebrpc@v0.37.0after upstream taggo test ./...passes.ridlfile withtype Foo: string— no error diagnostics, hover works