Fix narrow-import diagnostic including transitive types#6
Merged
Conversation
The narrowing diagnostic used exportedSchemaNames(importResult.Schema) which walks the fully resolved schema — including all transitively imported types. This caused the "can be narrowed" suggestion to list types from transitive imports (e.g. if project.ridl imports common.ridl, narrowing project.ridl would also list common.ridl's types). Switch to locallyDefinedNames(importResult.Root) which walks only the AST of the imported file, returning just the types/enums/errors/aliases defined directly in that file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
project.ridlimportscommon.ridl, narrowingproject.ridlwould also listcommon.ridl's types)locallyDefinedNames(importResult.Root)which only walks the AST of the imported fileTest plan
TestNarrowImportExcludesTransitiveTypescovering the exact scenario