feat: Open text assets in code editor#5918
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
txt,csv,md,js,css,json,html,xml, andsvgwithout adding asset-specific language branches to the shared editorCmd/Ctrl+S, orCmd/Ctrl+Enterthrough the asset replacement pipelineImpact
Users can open, edit, and persist all text-based upload formats directly in the builder without replacing or reloading the canvas. New
text/*upload types will automatically become editable as plain text; installed syntax support is selected by MIME type.Validation
pnpm --filter @webstudio-is/builder test -- app/builder/features/text-file-editor/text-file-utils.test.ts app/builder/shared/assets/replace-asset.test.ts app/builder/shared/asset-manager/asset-manager.test.tsxpnpm --filter @webstudio-is/builder typecheckpnpm exec oxlint --deny-warnings <changed files>pnpm exec oxfmt --check <changed files>git diff --checkRef #5824