Added disk selection and exclusion of deactivated disks - #87
Open
GMasta2000 wants to merge 2 commits into
Open
Conversation
kobihk
suggested changes
Sep 11, 2022
kobihk
left a comment
kobihk
left a comment
Contributor
There was a problem hiding this comment.
@GMasta2000 Thanks for creating this PR for the master branch
to fix issue #86
|
|
||
| # Get the Attachments Disk | ||
| disk_attachments = vms_service.vm_service(vm.id).disk_attachments_service().list() | ||
| disksBackup = [] |
Contributor
There was a problem hiding this comment.
please use the python convention
https://peps.python.org/pep-0008/#function-and-variable-names
like:
Suggested change
| disksBackup = [] | |
| disks_backup = [] |
| # Get the Attachments Disk | ||
| disk_attachments = vms_service.vm_service(vm.id).disk_attachments_service().list() | ||
| disksBackup = [] | ||
| BootableOnly = config.get_bootable_only() |
Contributor
There was a problem hiding this comment.
same here ^^
Suggested change
| BootableOnly = config.get_bootable_only() | |
| bootable_only = config.get_bootable_only() |
Comment on lines
+378
to
+380
| # print disk_attachment.id | ||
| # break | ||
| # print disks_id[0].__dict__ |
Contributor
There was a problem hiding this comment.
if this code is not necessary maybe you can remove it
Suggested change
| # print disk_attachment.id | |
| # break | |
| # print disks_id[0].__dict__ |
|
|
||
| for disk_attachment in disksBackup: | ||
| if disk_attachment.bootable == True: | ||
| logger.info("Finding bootable disk: %s", disk_attachment.id) |
Contributor
There was a problem hiding this comment.
maybe it will be better to use the new python3 format like:
Suggested change
| logger.info("Finding bootable disk: %s", disk_attachment.id) | |
| logger.info(f"Finding bootable disk: {disk_attachment.id}") |
IMHO it looks better and more readable.
| if disk_attachment.bootable == True: | ||
| logger.info("Finding bootable disk: %s", disk_attachment.id) | ||
| else: | ||
| logger.info("Finding disk: %s", disk_attachment.id) |
Contributor
There was a problem hiding this comment.
same ^^
Suggested change
| logger.info("Finding disk: %s", disk_attachment.id) | |
| logger.info(f"Finding disk: {disk_attachment.id}") |
| # Backup deactivated disks, set to False to skip deactivated disks backup (Recommend). | ||
| # This True - causes an error deleting a snapshot of the VM when the state is on. | ||
| with_disks_deactivated=False | ||
| # an array of exclude disks id,exampel ["6d811aa25-52a1-45c3-9f40-1c7c868182c9","6e78d7c2-5786-4dz2-a966-fd308c23f08e"] |
Contributor
There was a problem hiding this comment.
typo
Suggested change
| # an array of exclude disks id,exampel ["6d811aa25-52a1-45c3-9f40-1c7c868182c9","6e78d7c2-5786-4dz2-a966-fd308c23f08e"] | |
| # an array of exclude disks id, example ["6d811aa25-52a1-45c3-9f40-1c7c868182c9","6e78d7c2-5786-4dz2-a966-fd308c23f08e"] |
Author
|
@kobihk Thanks, I changed the variables. |
kobihk
approved these changes
Sep 15, 2022
Contributor
|
Hi @wefixit-AT |
roniezr
approved these changes
Sep 20, 2022
Contributor
|
Hi @wefixit-AT |
Contributor
|
Hi @wefixit-AT ^^??? |
richard-tns
added a commit
to richard-tns/oVirtBackup
that referenced
this pull request
Dec 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have transferred the changes that I made in 4.3 for disk filtering and additionally added default values for these parameters in config.py.