fix infinite loop on connection failures#303
Open
sorc1 wants to merge 1 commit intoweibocom:masterfrom
Open
Conversation
ngx_http_upsync_connect_handler(): When ngx_event_connect_peer() fails, we shouldn't set the current timer timeout to 0 as that immediatelly calls the current function again. Instead, we should call ngx_http_upsync_clean_event() to properly clean up & to set the reconnection timer.
sorc1
force-pushed
the
fix-infinite-loop
branch
from
ef97046 to
53d1062
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ngx_http_upsync_connect_handler():
When ngx_event_connect_peer() fails, we shouldn't set the current
timer to 0 as that immediatelly calls the current function
again. Instead, we should call ngx_http_upsync_clean_event() to
properly clean up & to set the reconnection timer.
It is easy to reproduce the bug on linux: on the nginx side try to block etcd IP address with a command below:
ip ro add unreach 1.1.1.1(to remove the rule, run
ip ro del unreach 1.1.1.1)