Fixing an infinite loop scenario in case of memory exhaustion#1266
Open
jvanegue wants to merge 1 commit intoweidai11:masterfrom
Open
Fixing an infinite loop scenario in case of memory exhaustion#1266jvanegue wants to merge 1 commit intoweidai11:masterfrom
jvanegue wants to merge 1 commit intoweidai11:masterfrom
Conversation
Throwing an exception after 10 attempts rather than trying to allocate indefinitely (which could be infinite)
Author
|
Any update on the above? This file has two distinct locations where this problem may happen. |
Author
|
Hello! Have you considered accept this PR? This introduces a fuel pattern for your allocations to avoid potential infinite loops. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throwing an exception after 10 attempts rather than trying to allocate indefinitely (which could be infinite)