You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Dec 11, 2023. It is now read-only.
Sorry, to have you hanging here. I appreciate your work and enthusiasm. 🙏🏾
Some days ago I started to refactor some code to allow the extraction of protocol related stuff. The idea is to have a Lua class like object representation (kind of like it is now) for the structures the protocol defines. Independent of features for this specific plugin. And then I started to add an interface that is meant to wrap the language clients. This can be then implemented to provide the logic for the communication with the actual client implementation (e.g. NeoVim native LSP, CoC, vim-lsp, ...) and returns these standardized structures as the protocol defines. The intention is to make this code standalone and exportable into a Luarocks library or/and a utility plugin that can be used by any plugin out there that uses LSP features, but wants to be independent of which client the user uses (as now here with CoC for example).
Unfortunately I have a lot of load at work right now and this is a little more complex and I need time and piece to work on it. If I'm there that I can share it, I would love to ask you if you could implement the wrapper for the CoC client. Until then I hope everyone is fine to set their plugin managers to use this PR here.
I'm sorry that this takes longer than someone might have expected. This is a serious feature and a big topic architecture wise. Not only for this plugin. We might have an opportunity here to improve many other plugins as well (I plan to use this in my other plugins plus some I have in mind for the future).
The data structures these clients return should be the same.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vim.notifyinstead ofvim.api.nvim_notify