fix: retain standalone integration traces - #1
Draft
weivwang wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
start_span()calls made outside an explicit trace as queryable one-span tracestrace_start/trace_endlifecycle events used by explicit tracesWhy
The zero-config OpenAI and Anthropic integrations call
start_span()directly. When an application used the documentedinstrument_all()flow without wrapping every SDK call instart_trace(), the span completed but was never added to_traces. Dashboards and exporters therefore saw no trace even though instrumentation ran successfully.Impact
Auto-instrumented provider calls now remain visible without requiring an undocumented explicit trace wrapper. Existing spans inside an explicit trace keep their current parent-child behavior.
Validation
uv run --with pytest --with pytest-asyncio pytest -q— 41 passeduv build— wheel and source distribution built successfullygit diff --checkThe repository's existing
ruff check agent_trace/baseline is currently not clean (pre-existing import-order, unused-import, line-length, and Python-3.9-incompatible UP045 findings); this PR does not broaden scope into a repository-wide formatting migration.