Skip to content

fix: support skipVirtualDrivesRemoval override from api #2288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kristina-solovyova wants to merge 1 commit into from
Closed

fix: support skipVirtualDrivesRemoval override from api #2288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/controllers/wekacontainer/funcs_drives.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -660,7 +660,7 @@ func (r *containerReconcilerLoop) removeDriveFromWeka(ctx context.Context, drive

logger.Info("Drive removed from weka")

if useDriveSharing {
if useDriveSharing && !r.container.Spec.GetOverrides().SkipVirtualDrivesRemoval {
// remove virtual drive on ssdproxy
err = r.removeVirtualDrive(ctx, drive.Uuid)
if err != nil {
Expand Down
5 changes: 5 additions & 0 deletions internal/controllers/wekacontainer/funcs_virtual_drives.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,11 @@ func (r *containerReconcilerLoop) RemoveVirtualDrives(ctx context.Context) error
ctx, logger, end := instrumentation.GetLogSpan(ctx, "RemoveVirtualDrives")
defer end()

if container.Spec.GetOverrides().SkipVirtualDrivesRemoval {
logger.Info("Skipping virtual drive removal as requested via SkipVirtualDrivesRemoval override")
return nil
}

// Only for drive sharing mode
if !container.UsesDriveSharing() {
logger.Debug("Container not using drive sharing, skipping virtual drive removal")
Expand Down
Loading