Fix t:Data.Parser.KV.field_spec/2 and t:Data.Parser.KV.field/2#11
Open
zachallaun wants to merge 2 commits intowell-ironed:masterfrom
Open
Fix t:Data.Parser.KV.field_spec/2 and t:Data.Parser.KV.field/2#11zachallaun wants to merge 2 commits intowell-ironed:masterfrom
t:Data.Parser.KV.field_spec/2 and t:Data.Parser.KV.field/2#11zachallaun wants to merge 2 commits intowell-ironed:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
t:field_spec/2, the type variablesaandbcorrespond toParser.t(a, b), whereais the success type andbis the failure type. The type definition callsfield_opts(b), defined as:This would suggest that the
:defaultwould be the failure typeb, while it should actually be a default corresponding to the success typea.The opaque
t:field/2had the same issue.t:Data.Parser.KV.field_spec/2andt:Data.Parser.KV.field/2Note that the "0.6.0" tag seems to be missing in this repo at the moment.