Midend Optimizations - #28
Open
yelhsams wants to merge 10 commits into
Open
Conversation
avanhatt
reviewed
Apr 30, 2025
| src_opts.join("spaceship.isle"), | ||
| src_opts.join("spectre.isle"), | ||
| src_opts.join("vector.isle"), | ||
| // inst_tags_isle.clone(), |
There was a problem hiding this comment.
Reminder to remove commented out code
| ], | ||
| untracked_inputs: vec![clif_opt_isle], | ||
| rule_trace: false, | ||
| // "lower" -- replace |
| ;; the right, and thus only simplify patterns like `x+0`, not `0+x`. | ||
|
|
||
| ;; x+0 == x. | ||
| (rule iadd_zero (simplify (iadd ty |
There was a problem hiding this comment.
Let's move these back to their original file (as in, put the rule names on the original rules) before we merge
| } | ||
|
|
||
| // For midend (opt) missing defs | ||
| // filter out Instantiations without declaration in termenv |
| fn collect_specs(&mut self, defs: &[Def], termenv: &TermEnv, tyenv: &TypeEnv) -> Result<()> { | ||
| for def in defs { | ||
| // For midend (opt) missing defs | ||
| // filter out Instantiations without declaration in termenv |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far, all of
arithmetic.isleis verified, with the exception of NaN propagations for FP rules. Finding a suitable spec for simplify is still in progress.