fix: add -buildvcs=false to Linux container builds#230
Merged
Conversation
Go build fails with "error obtaining VCS status: exit status 128" inside manylinux Docker containers because git safe.directory is not configured. Version info is already stamped via ldflags, so VCS stamping is redundant. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
roborev: Combined Review (
|
build-linux failures inside manylinux containers should not prevent the GitHub release or PyPI publish from running with the platforms that did succeed (macOS, Windows). - Add if conditions so release runs when build succeeds regardless of build-linux result - Same for pypi: runs when release succeeds - Remove --require-all from wheel builder so it packages whatever platforms are available - Make smoke test conditional on Linux wheel existence Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
roborev: Combined Review (
|
PyPI should have all platform wheels, so keep build-linux as a hard requirement for the pypi job. Only the GitHub release is non-blocking. Restores --require-all and the direct smoke test. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
All builds must succeed before release or pypi runs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
roborev: Combined Review (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-buildvcs=falseto thego buildcommand in thebuild-linuxjoberror obtaining VCS status: exit status 128when building inside manylinux Docker containers where gitsafe.directoryis not configured-ldflags, so VCS stamping is redundantFailed run: https://github.com/wesm/agentsview/actions/runs/23521504471
Test plan
🤖 Generated with Claude Code