Dev - #774
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
⏳ CI 检查进行中，报告将在完成后更新。 |
Reviewer's Guide将 20260813 CN 活动（“Depths of the Astrarium”）的地图更新为使用新的 Bonhomme Richard 塞壬模板，调整相机出生点和滑动/视野调优参数，并将新的活动及其资产接入战役元数据和模板系统。 File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your Experience访问你的 dashboard 以：
Getting HelpOriginal review guide in EnglishReviewer's GuideUpdates the 20260813 CN event (“Depths of the Astrarium”) maps to use new Bonhomme Richard siren templates, adjusts camera spawn points and swipe/vision tuning parameters, and wires the new event and assets into the campaign meta data and template system. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - 我在这里提供一些总体反馈：
- 在多个关卡（例如 A1、C1、A2、C2、A3、C3）中，MAP_HAS_SIREN 仍然为 True，但 MAP_SIREN_TEMPLATE 被设置为空列表；建议要么关闭 MAP_HAS_SIREN，要么显式提供模板，以避免出现意外的警报处理行为。
- INTERNAL_LINES_FIND_PEAKS_PARAMETERS / EDGE_LINES_FIND_PEAKS_PARAMETERS 以及 MAP_SWIPE_MULTIPLY 这些元组在多个地图中被重复定义，且数值非常接近；建议将它们集中到共享常量或辅助函数中，以减少重复并方便之后的参数调优。
- 与章节/档期相关的标志位（MAP_CHAPTER_SWITCH_20241219、STAGE_ENTRANCE、MAP_HAS_MODE_SWITCH、STAGE_INCREASE_AB、MAP_WALK_USE_CURRENT_FLEET）在一些 20260813 CN 地图中存在，而在另一些中被移除；可以考虑在所有活动关卡之间统一这些配置，以保证活动流程行为的一致性。
提供给 AI Agents 的提示
Please address the comments from this code review:
## Overall Comments
- Several stages (e.g., A1, C1, A2, C2, A3, C3) keep MAP_HAS_SIREN = True while MAP_SIREN_TEMPLATE is set to an empty list; consider either disabling MAP_HAS_SIREN or wiring an explicit template to avoid unexpected siren handling.
- The INTERNAL_LINES_FIND_PEAKS_PARAMETERS / EDGE_LINES_FIND_PEAKS_PARAMETERS and MAP_SWIPE_MULTIPLY tuples are duplicated with very similar values across multiple maps; consider centralizing these into shared constants or helpers to reduce repetition and ease future tuning.
- Chapter/schedule-related flags (MAP_CHAPTER_SWITCH_20241219, STAGE_ENTRANCE, MAP_HAS_MODE_SWITCH, STAGE_INCREASE_AB, MAP_WALK_USE_CURRENT_FLEET) are present on some 20260813 CN maps but removed on others; it may be worth aligning these configurations across all event stages to keep campaign behavior consistent.帮我变得更有用！请在每条评论上点 👍 或 👎，我会根据你的反馈不断改进代码审查质量。
Original comment in English
Hey - I've left some high level feedback:
- Several stages (e.g., A1, C1, A2, C2, A3, C3) keep MAP_HAS_SIREN = True while MAP_SIREN_TEMPLATE is set to an empty list; consider either disabling MAP_HAS_SIREN or wiring an explicit template to avoid unexpected siren handling.
- The INTERNAL_LINES_FIND_PEAKS_PARAMETERS / EDGE_LINES_FIND_PEAKS_PARAMETERS and MAP_SWIPE_MULTIPLY tuples are duplicated with very similar values across multiple maps; consider centralizing these into shared constants or helpers to reduce repetition and ease future tuning.
- Chapter/schedule-related flags (MAP_CHAPTER_SWITCH_20241219, STAGE_ENTRANCE, MAP_HAS_MODE_SWITCH, STAGE_INCREASE_AB, MAP_WALK_USE_CURRENT_FLEET) are present on some 20260813 CN maps but removed on others; it may be worth aligning these configurations across all event stages to keep campaign behavior consistent.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Several stages (e.g., A1, C1, A2, C2, A3, C3) keep MAP_HAS_SIREN = True while MAP_SIREN_TEMPLATE is set to an empty list; consider either disabling MAP_HAS_SIREN or wiring an explicit template to avoid unexpected siren handling.
- The INTERNAL_LINES_FIND_PEAKS_PARAMETERS / EDGE_LINES_FIND_PEAKS_PARAMETERS and MAP_SWIPE_MULTIPLY tuples are duplicated with very similar values across multiple maps; consider centralizing these into shared constants or helpers to reduce repetition and ease future tuning.
- Chapter/schedule-related flags (MAP_CHAPTER_SWITCH_20241219, STAGE_ENTRANCE, MAP_HAS_MODE_SWITCH, STAGE_INCREASE_AB, MAP_WALK_USE_CURRENT_FLEET) are present on some 20260813 CN maps but removed on others; it may be worth aligning these configurations across all event stages to keep campaign behavior consistent.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
为“深渊星仪（Depths of the Astrarium）”配置 20260813 CN 活动地图，包括更新的塞壬 Boss、相机设置以及输入调优参数。
New Features:
Enhancements:
Documentation:
Chores:
Original summary in English
Summary by Sourcery
Configure the 20260813 CN event maps for "Depths of the Astrarium", including updated siren bosses, camera settings, and input tuning parameters.
New Features:
Enhancements:
Documentation:
Chores: