Fix html5 playback#31
Conversation
| if(preg_match("/^https?/", $input)) | ||
| return "<video $attributes><source src='{$input}'></video>"; |
There was a problem hiding this comment.
I don't like this solution as it could result in video files being embedded from remote hosts. I think if a URL is detected you should use parse_url to extract the path
There was a problem hiding this comment.
"Video files from remote hosts" is a feature not a bug; we want to use CDNs to host the video files, not just serve the video files from the sync instance ie. clients start their session with theatre.wetfish.net, but video files are served from a geolocated loadbalancing cache cdn.wetfish.net .
But there should be a better way than writing an if-exception-then. (new URL($input, $session_baseurl)).href ?
There was a problem hiding this comment.
@mozai this is for the wiki. This has nothing to do with the sync project
3 participants
Don't use a leading path for http inputs