Skip to content

fix(core): preserve multi-chain getClient action typing#5075

Closed
fuyua9 wants to merge 2 commits into
wevm:mainfrom
fuyua9:devb/wagmi-getclient-fuyua9
Closed

fix(core): preserve multi-chain getClient action typing#5075
fuyua9 wants to merge 2 commits into
wevm:mainfrom
fuyua9:devb/wagmi-getclient-fuyua9

Conversation

@fuyua9

@fuyua9 fuyua9 commented Apr 23, 2026

Copy link
Copy Markdown

Summary

  • add a type regression covering waitForTransactionReceipt(getClient(config), ...) with a multi-chain config
  • preserve the full multi-chain action client type by avoiding distributive conditional behavior in GetClientReturnType

Testing

  • pnpm bench:types packages/core/src/actions/getClient.test-d.ts

Closes #3635

@vercel

vercel Bot commented Apr 23, 2026

Copy link
Copy Markdown

@fuyua9 is attempting to deploy a commit to the Wevm Team on Vercel.

A member of the Team first needs to authorize it.

@changeset-bot

changeset-bot Bot commented Apr 23, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: ece6a1d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@wagmi/core Patch
@wagmi/connectors Patch
wagmi Patch
@wagmi/solid Patch
@wagmi/vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@fuyua9

fuyua9 commented Apr 25, 2026

Copy link
Copy Markdown
Author

Added a patch changeset for @wagmi/core in ece6a1d so the changeset bot can classify this getClient typing fix for release.

Local validation: git diff --check passed. I did not rerun the full type suite here because this follow-up only adds a changeset file and the worktree did not have dependencies installed.

@tmm

tmm commented Jun 22, 2026

Copy link
Copy Markdown
Member

Closing as a duplicate of #5136, which includes the same getClient typing fix with broader coverage. Thanks for the PR!

@tmm tmm closed this Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: waitForTransactionReceipt doesn't accept client with multiple possible chains

2 participants