Skip to content

fix(core): preserve tempo prepare transaction types#5129

Open
deodad wants to merge 2 commits into
wevm:mainfrom
deodad:dad/tempo-transaction-types
Open

fix(core): preserve tempo prepare transaction types#5129
deodad wants to merge 2 commits into
wevm:mainfrom
deodad:dad/tempo-transaction-types

Conversation

@deodad

@deodad deodad commented May 19, 2026

Copy link
Copy Markdown
Contributor

Summary

Preserve Tempo transaction request narrowing through wagmi's prepareTransactionRequest types.

Motivation

viem 2.50.4 includes the Tempo prepareTransactionRequest narrowing fix, but wagmi still needed coverage and overloads that infer the literal request shape when a chainId is supplied.

Changes

  • Bumped viem to 2.50.4.
  • Added prepareTransactionRequest overloads that keep chainId and request literals available to the return type.
  • Added a Tempo type regression for prepared requests with type: 'tempo'.
  • Updated the Tempo wallet deposit test for viem's amount parameter rename.

Testing

  • pnpm --filter @wagmi/core check:types
  • pnpm vitest run packages/core/src/actions/prepareTransactionRequest.test.ts packages/core/src/tempo/actions/wallet.test.ts (fails in this environment: prepareTransactionRequest tests hit local RPC 400/timeouts after binding the test port; the Tempo wallet test file passed)

@vercel

vercel Bot commented May 19, 2026

Copy link
Copy Markdown

@deodad is attempting to deploy a commit to the Wevm Team on Vercel.

A member of the Team first needs to authorize it.

@changeset-bot

changeset-bot Bot commented May 19, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 52a386c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@wagmi/core Patch
@wagmi/connectors Patch
wagmi Patch
@wagmi/solid Patch
@wagmi/vue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented May 19, 2026

Copy link
Copy Markdown

Open in StackBlitz

@wagmi/cli

npm i https://pkg.pr.new/@wagmi/cli@5129

@wagmi/connectors

npm i https://pkg.pr.new/@wagmi/connectors@5129

@wagmi/core

npm i https://pkg.pr.new/@wagmi/core@5129

create-wagmi

npm i https://pkg.pr.new/create-wagmi@5129

wagmi

npm i https://pkg.pr.new/wagmi@5129

@wagmi/solid

npm i https://pkg.pr.new/@wagmi/solid@5129

@wagmi/vue

npm i https://pkg.pr.new/@wagmi/vue@5129

commit: 52a386c

@deodad deodad closed this May 19, 2026
@deodad deodad reopened this May 26, 2026
@deodad
deodad force-pushed the dad/tempo-transaction-types branch from 67a4837 to 6bb7da5 Compare May 26, 2026 21:36
@deodad
deodad marked this pull request as ready for review May 26, 2026 21:45
@deodad
deodad force-pushed the dad/tempo-transaction-types branch from 6bb7da5 to 52a386c Compare May 26, 2026 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant