Using commit hashes rather than static versions in GHA #232
Closed
jsphwhereby wants to merge 1 commit intomainfrom
Closed
Using commit hashes rather than static versions in GHA #232jsphwhereby wants to merge 1 commit intomainfrom
jsphwhereby wants to merge 1 commit intomainfrom
Conversation
Contributor
|
I believe this repo is no longer used, it can probably be archived actually right @thyal ? |
Contributor
Correct. |
Author
Makes me job easier, thanks guys :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary:
Following the incident regarding tj-actions we have decided to use commit hashes rather than static versions in our GHAs.
Related Issue:
https://linear.app/whereby/issue/BATT-824/pin-external-github-actions-down-by-commit-hash-rather-than-release
Testing
No changes, the version is the same as the commit hash, this just prevents versions from being overridden with malicious code.
Screenshots/GIFs (if applicable)
Checklist
under the terms of the MIT license.
Dependency Updates
Reviewers
@havardholvik
@kevinwhereby
@nandito
@thyal
Additional Information