media: Replace rtcStats singleton with factory function#832
Open
havardholvik wants to merge 2 commits intomainfrom
Open
media: Replace rtcStats singleton with factory function#832havardholvik wants to merge 2 commits intomainfrom
havardholvik wants to merge 2 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: aa2e9eb The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
|
/canary |
havardholvik
force-pushed
the
havard/cob-2302-sdk-replace-singleton-rtcstats-connection-with-factory
branch
from
db26008 to
3ae50b3
Compare
Contributor
Author
|
/canary |
havardholvik
force-pushed
the
havard/cob-2302-sdk-replace-singleton-rtcstats-connection-with-factory
branch
from
3ae50b3 to
5502b2a
Compare
Contributor
Author
|
/canary |
1 similar comment
Contributor
Author
|
/canary |
Contributor
|
🚀 The canary releases have been published to npm. You can test the releases by installing the newly published versions: pnpm add @whereby.com/assistant-sdk@0.0.0-canary-20251218205351pnpm add @whereby.com/browser-sdk@0.0.0-canary-20251218205351pnpm add @whereby.com/core@0.0.0-canary-20251218205351pnpm add @whereby.com/media@0.0.0-canary-20251218205351pnpm add @whereby.com/react-native-sdk@0.0.0-canary-20251218205351 |
kevinwhereby
approved these changes
Dec 19, 2025
Contributor
kevinwhereby
left a comment
kevinwhereby
left a comment
There was a problem hiding this comment.
Added all the piping to init this in bundles/stats.js and pass it around where required and it all works as expected 🎉
havardholvik
force-pushed
the
havard/cob-2302-sdk-replace-singleton-rtcstats-connection-with-factory
branch
2 times, most recently
from
f6fb6f3 to
429aeeb
Compare
Contributor
Author
|
/canary |
Contributor
|
🚀 The canary releases have been published to npm. You can test the releases by installing the newly published versions: pnpm add @whereby.com/assistant-sdk@0.0.0-canary-20260107113229pnpm add @whereby.com/browser-sdk@0.0.0-canary-20260107113229pnpm add @whereby.com/core@0.0.0-canary-20260107113229pnpm add @whereby.com/media@0.0.0-canary-20260107113229pnpm add @whereby.com/react-native-sdk@0.0.0-canary-20260107113229 |
havardholvik
force-pushed
the
havard/cob-2302-sdk-replace-singleton-rtcstats-connection-with-factory
branch
from
429aeeb to
d015099
Compare
Contributor
Author
|
/canary |
Contributor
|
🚀 The canary releases have been published to npm. You can test the releases by installing the newly published versions: pnpm add @whereby.com/assistant-sdk@0.0.0-canary-20260108073026pnpm add @whereby.com/browser-sdk@0.0.0-canary-20260108073026pnpm add @whereby.com/core@0.0.0-canary-20260108073026pnpm add @whereby.com/media@0.0.0-canary-20260108073026pnpm add @whereby.com/react-native-sdk@0.0.0-canary-20260108073026 |
Due to breaking change in media package, this connection needs to be initialized outside the media package itself.
havardholvik
force-pushed
the
havard/cob-2302-sdk-replace-singleton-rtcstats-connection-with-factory
branch
from
d015099 to
aa2e9eb
Compare
Contributor
Author
|
/canary |
Contributor
|
🚀 The canary releases have been published to npm. You can test the releases by installing the newly published versions: pnpm add @whereby.com/assistant-sdk@0.0.0-canary-20260113080148pnpm add @whereby.com/browser-sdk@0.0.0-canary-20260113080148pnpm add @whereby.com/core@0.0.0-canary-20260113080148pnpm add @whereby.com/media@0.0.0-canary-20260113080148pnpm add @whereby.com/react-native-sdk@0.0.0-canary-20260113080148 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary:
Replace singleton rtcStats connection object with factory function for better lifecycle control and testability.
Related Issue:
Testing
Unit tests added.
Checklist
under the terms of the MIT license.