Skip to content

media/core: use new APIs for adding and removing streams#907

Open
pnts-se-whereby wants to merge 12 commits intomainfrom
pontus/refactor-rtc-managers
Open

media/core: use new APIs for adding and removing streams#907
pnts-se-whereby wants to merge 12 commits intomainfrom
pontus/refactor-rtc-managers

Conversation

@pnts-se-whereby
Copy link
Contributor

@pnts-se-whereby pnts-se-whereby commented Mar 12, 2026

Description

Summary:

  • use explicit APIs for camera/screenshare streams
  • make code related to custom browser-sdk stopresumevideo event more clear about its purpose
  • remove P2P analytics no longer needed
  • remove unused code

Related Issue:

Testing

Screenshots/GIFs (if applicable)

Checklist

  • My code follows the project's coding standards.
  • Prefixed the PR title and commit messages with the service or package name
  • I have written unit tests (if applicable).
  • I have updated the documentation (if applicable).
  • By submitting this pull request, I confirm that my contribution is made
    under the terms of the MIT license.

Additional Information

@changeset-bot
Copy link

changeset-bot bot commented Mar 12, 2026

🦋 Changeset detected

Latest commit: c2d1adc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@whereby.com/media Major
@whereby.com/core Patch
@whereby.com/browser-sdk Patch
@whereby.com/assistant-sdk Patch
@whereby.com/react-native-sdk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pnts-se-whereby pnts-se-whereby force-pushed the pontus/refactor-rtc-managers branch from eab03d8 to 5f880e3 Compare March 12, 2026 09:39
@pnts-se-whereby
Copy link
Contributor Author

/canary

@github-actions
Copy link
Contributor

🚀 The canary releases have been published to npm.

You can test the releases by installing the newly published versions:

pnpm add @whereby.com/assistant-sdk@0.0.0-canary-20260312122702
pnpm add @whereby.com/browser-sdk@0.0.0-canary-20260312122702
pnpm add @whereby.com/core@0.0.0-canary-20260312122702
pnpm add @whereby.com/media@0.0.0-canary-20260312122702
pnpm add @whereby.com/react-native-sdk@0.0.0-canary-20260312122702

@pnts-se-whereby pnts-se-whereby force-pushed the pontus/refactor-rtc-managers branch 2 times, most recently from 42d6c27 to d54b2d1 Compare March 13, 2026 10:47
Copy link
Contributor

@havardholvik havardholvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ive now looked at the overall api changes, added some comments. Ive not reviewed any of the tests, nor done any testing of these changes myself. Ill leave that to someone else 👍

@pnts-se-whereby pnts-se-whereby force-pushed the pontus/refactor-rtc-managers branch from d54b2d1 to 2867ec3 Compare March 18, 2026 06:15
@pnts-se-whereby pnts-se-whereby changed the title media: refactor rtc managers media/core: refactor rtc managers Mar 18, 2026
@pnts-se-whereby
Copy link
Contributor Author

/canary

@github-actions
Copy link
Contributor

🚀 The canary releases have been published to npm.

You can test the releases by installing the newly published versions:

pnpm add @whereby.com/assistant-sdk@0.0.0-canary-20260318080320
pnpm add @whereby.com/browser-sdk@0.0.0-canary-20260318080320
pnpm add @whereby.com/core@0.0.0-canary-20260318080320
pnpm add @whereby.com/media@0.0.0-canary-20260318080320
pnpm add @whereby.com/react-native-sdk@0.0.0-canary-20260318080320

@pnts-se-whereby pnts-se-whereby changed the title media/core: refactor rtc managers media/core: use new APIs for adding and removing streams Mar 18, 2026
Copy link
Contributor

@kevinwhereby kevinwhereby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🧹

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants