Ensure states in replay buffer are stored as uint8 to reduce CPU memory.#7
Merged
Ensure states in replay buffer are stored as uint8 to reduce CPU memory.#7
Conversation
This change addresses a hypothesis that states might be stored with a larger data type (e.g., float32) in the replay buffer, contributing to high CPU memory usage. Modifies `RainbowAgent.store_experience` to: - Check the dtype of state and next_state. - Convert them to `np.uint8` if they are not already, before adding to the n-step buffer and subsequently the main replay buffer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change addresses a hypothesis that states might be stored with a larger data type (e.g., float32) in the replay buffer, contributing to high CPU memory usage.
Modifies
RainbowAgent.store_experienceto:np.uint8if they are not already, before adding to the n-step buffer and subsequently the main replay buffer.