Related issue: add duplicate-finder by tags/name (#882)#896
Open
Sasiprakash-UoA wants to merge 5 commits intowhyboris:mainfrom
Open
Related issue: add duplicate-finder by tags/name (#882)#896Sasiprakash-UoA wants to merge 5 commits intowhyboris:mainfrom
Sasiprakash-UoA wants to merge 5 commits intowhyboris:mainfrom
Conversation
Author
|
Thank you for reviewing this PR. I've addressed the Code Climate feedback by fully refactoring the findDuplicatesByTagsOrName() method into a concise, array-driven approach with significantly reduced cognitive complexity. The feature now detects duplicates by: Matching exact filenames Identifying repeated tags across videos The logic is cleaner, fully tested in the UI, and adheres to the project’s standards. Appreciate the opportunity to contribute to this project! |
Owner
|
Thank you @Sasiprakash-UoA 🥳 😁 🙇♂️ I appreciate the contribution. I hope to get to reviewing and merging this around the end of summer; thank you for your patience. Cheers 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #882 Find Duplicates by Tags or Name
What I did
Implemented a findDuplicatesByTagsOrName() method in ImageElementService to detect duplicates via exact filename matches and shared tags.
Seamlessly integrated a 🔍 icon into the TopComponent toolbar, styled in line with existing controls and equipped with a “Find duplicates with names/tags” tooltip.
Verified that the new feature coexists with the existing hash-based detection without regressions.
Thank you for maintaining this project and providing a clear, welcoming pathway for first-time contributors!