Enhance tag filtering and query handling in Meme components.#47
Open
Pdzly wants to merge 3 commits into
Open
Conversation
Contributor
|
Can you make the urls more readable like we have with the categories? Instead of category it is caregory__handle, similarly we can use tags__name by adding it to apps.rest.v0.views.post.PostViewSet.filterset_fields Also I haven't checked if this is solely from this PR but seems like it keeps trying to fetch more
Lastly, can you remove the console.logs Other than these this looks good and we can merge it after the changes above, thanks! |
# Conflicts: # wsd-frontend/src/components/wsd/Memes/Memes.tsx
Contributor
Author
|
From my perspective either with the changes i made now, it isnt fetching more than needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the ability to click tags and quick filter them with it.