Adapts threshold method to return worse-case confidence intervals correctly#241
Merged
guillermoaguilar merged 9 commits intowichmann-lab:mainfrom Jun 23, 2025
Merged
Conversation
Collaborator
|
@guillermoaguilar I can fix the tests |
guillermoaguilar
changed the title
pberkes
reviewed
Jun 19, 2025
Collaborator
pberkes
left a comment
pberkes
left a comment
There was a problem hiding this comment.
I think there's a problem with the way the CI bounds for gamma and lambda are set, I'm pushing a proposal that fixes it in a minute
guillermoaguilar
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially fixes #191
However, the function does not take a vectorized form for proportion_correct
--> DONE
And the tests need to be changed, the expected values were manually added.
I need help with that, could you help @pberkes ?