This repository was archived by the owner on Aug 20, 2018. It is now read-only.
Now showing alert when no available audio#34
Open
hy-cheng wants to merge 1 commit intowikimedia:masterfrom
Open
Now showing alert when no available audio#34hy-cheng wants to merge 1 commit intowikimedia:masterfrom
hy-cheng wants to merge 1 commit intowikimedia:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
This will need to be localized. Otherwise it looks good though, but we should talk it over at our next meeting if this is how we want to address this issue.
Member
There was a problem hiding this comment.
IMO this should be merged if @hy-cheng isnt going to be fixing this. Someone else can then do the l10n.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Listen-in button is now not darkened and disabled where there is nothing to play, and will show a notification with a helpful message instead. I think its a lot more intuitive than what we had before.
As far as I can tell, I can't both darken and show a notification.