Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the project’s dev test tooling to PHPUnit 10.x in order to address reported security concerns (per T411267).
Changes:
- Bump
phpunit/phpunitdev requirement from 9.6.34 to^10.1. - Regenerate
composer.lockto reflect the PHPUnit 10 dependency graph (phpunit/* and sebastian/* package updates/removals).
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| composer.json | Updates the PHPUnit version constraint to allow PHPUnit 10.x. |
| composer.lock | Locks updated PHPUnit 10.x and related dependency versions, removing now-unneeded packages. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
9.6.34 is already safe from CVE-2026-24765. As Co-pilot says, if you're upgrading to PHPUnit 10.x (as we should!) is moderately more involved. For MW it's very complicated (see T328919), but updating the PHPUnit config in phpunit.xml is best done in this PR. |
|
I think this is now a worse commit? We've gone from fixed, known version of PHPUnit to a floating one. |
I'll just update to PHPUnit 10. |
Abijeet
changed the title
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Fixes #468
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This runs all the necessary checks and tests.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Fixes #466
Fixes #467
Fixes #468
Fixes #469
Please review each commit at a time.
Merge strategy: Rebase and merge
Bug: https://phabricator.wikimedia.org/T411267