Open
Conversation
Modified `wt_session.py` to support `appId`, and tweaked the code to support unauthenticated requests. Added `example.py` for testing. Also fixed a quick typo in the `README.md`
|
Thanks Steve! |
ronaldbradford
left a comment
ronaldbradford
left a comment
There was a problem hiding this comment.
I'm new to WikiTree APIs (been a WikiTree contributor for a while), not new to Python.
I checked out the fork branch and the example.py works as expected, unauthenticated and authenticated. 👍
I provided a suggestion that enables the example to be more flexible for anybody to vett.
KEY=Bradford-8102 python example.py
|
|
||
|
|
||
| APP_ID = "Python3-SessionExample" | ||
| KEY = "Windsor-1" |
There was a problem hiding this comment.
Suggested improvement.
APP_ID = os.environ.get("APP_ID", "Python3-SessionExample")
KEY = os.environ.get("KEY", "Windsor-1")
| - wt_session.py in the same folder (your updated version that supports unauthenticated use + appId) | ||
| - requests installed | ||
| """ | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified
wt_session.pyto supportappId, and tweaked the code to support unauthenticated requests. Addedexample.pyfor testing. Also fixed a quick typo in theREADME.md