[ELY-3033] Add JPMS module-info.java files for all non-deprecated modules#2424
[ELY-3033] Add JPMS module-info.java files for all non-deprecated modules#2424tristantarrant wants to merge 1 commit intowildfly-security:2.xfrom
Conversation
…ules Resolve split packages: - Move SSLConnection/TLSServerEndPointChannelBinding from auth-server's o.w.s.ssl to o.w.s.auth.ssl - Move PasswordEntry/PasswordKeyStoreSpi from credential's o.w.s.keystore to o.w.s.credential.keystore - Move auth/client's o.w.s.auth.util to o.w.s.auth.client.util - Move auth/client's o.w.s.credential.source to o.w.s.auth.client.credential Add module-info.java to 67 modules with proper requires, exports, and provides directives. Include generate-module-info.py script. Notable decisions: - Skip wildfly-elytron-security-manager (compiled with Java 8) - Export mechanism._private to all modules (used by 20+ consumers) - Use requires transitive for jackson deps in jose-util - Skip deprecated modules per project convention
|
Hi @tristantarrant , just wondering if the ELY-???? means that it was not possible to create jira issue? |
Indeed. If you create an issue for me, I'll amend the commit and PR title |
|
@tristantarrant I've created https://redhat.atlassian.net/browse/ELY-3033 issue, you can adjust description if needed and add the issue number to commit. And you should have the permissions in jira now. Thank you |
|
Some of the classes moved here look like they may be public API. |
| @@ -0,0 +1,15 @@ | |||
| module org.wildfly.security.auth.realm.token { | |||
There was a problem hiding this comment.
What is the strategy that can be used to understand why the proposed module definitions are define the way they are?
How do we verify this is the correct list of requires and how do we confirm what the correct list of exports is?
Does this work consider the use of WildFly Elytron in other contexts such as in WildFly or in issolation to the project.
skyllarr
changed the title
skyllarr
changed the title
3 participants
No description provided.