Skip to content

[WFSSL-92] Allow using EC certificates with OpenSSL#117

Open
rmartinc wants to merge 1 commit intowildfly-security:mainfrom
rmartinc:WFSSL-92
Open

[WFSSL-92] Allow using EC certificates with OpenSSL#117
rmartinc wants to merge 1 commit intowildfly-security:mainfrom
rmartinc:WFSSL-92

Conversation

@rmartinc
Copy link
Copy Markdown
Contributor

@rmartinc rmartinc commented Feb 3, 2022

Adding EC to the allowed key/certificate algorithm list. The BasicOpenSSLSocketECTest checks a TLSv1.2 and TLSv1.3 connection between client and server using EC certificates (mutual SSL auth).

@rmartinc
Copy link
Copy Markdown
Contributor Author

rmartinc commented Feb 3, 2022

@fjuma I think this line is not correct, it should be the last version released 2.2.0.Final. If not the artifact is not found for windows and macos during the CI. Thanks!

@fjuma
Copy link
Copy Markdown
Contributor

fjuma commented Feb 3, 2022

@rmartinc Good catch, you are correct! If you have a sec and wanted to submit a PR to fix that, that would be great. Otherwise, I'll try to do that later today.

@rmartinc
Copy link
Copy Markdown
Contributor Author

rmartinc commented Feb 3, 2022

Done in #118! I'll rebase this one once the other is merged. Thanks!

@rmartinc
Copy link
Copy Markdown
Contributor Author

@fjuma remember that this PR is here. It's a small fix but it would be good to have EC also in openssl.

@fjuma
Copy link
Copy Markdown
Contributor

fjuma commented Mar 17, 2022

Thanks for the reminder, @rmartinc!

@rmartinc
Copy link
Copy Markdown
Contributor Author

rmartinc commented Sep 6, 2022

@fjuma Do you think this is interesting? I'm just going over my list of PRs...

@darranl
Copy link
Copy Markdown
Contributor

darranl commented Nov 19, 2025

Just catching up on old PRs on this project.

I am not familiar with how other keystores are managed on this project yet but in general I am not a fan of keystores in source code without at least some docuementation describing how to create them.

Ideally though I prefer them to be created on demand so we know they are not going to expire / need replacing etc...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants