WFSSL-112 Use PooledByteBuffer to fix performance issue caused by ByteBuffer allocation

java/src/main/java/org/wildfly/openssl/OpenSSLEngine.java

@@ -61,6 +61,7 @@ public final class OpenSSLEngine extends SSLEngine {
     }
 
     static final int MAX_PLAINTEXT_LENGTH = 16 * 1024; // 2^14
+    static final boolean USE_POOLED_BYTEBUFFER = Boolean.getBoolean("org.wildfly.openssl.use-pooled-buffer");
     private static final int MAX_COMPRESSED_LENGTH = MAX_PLAINTEXT_LENGTH + 1024;
     private static final int MAX_CIPHERTEXT_LENGTH = MAX_COMPRESSED_LENGTH + 1024;
 
@@ -254,7 +255,8 @@ private int writePlaintextData(final ByteBuffer src) {
                 return sslWrote;
             }
         } else {
-            ByteBuffer buf = ByteBuffer.allocateDirect(len);
+            final ByteBufferAllocator allocator = getByteBufferAllocator();
+            final ByteBuffer buf = allocator.allocate(len);
             try {
                 final long addr = memoryAddress(buf);
 
@@ -271,8 +273,7 @@ private int writePlaintextData(final ByteBuffer src) {
                     src.position(pos);
                 }
             } finally {
-                buf.clear();
-                ByteBufferUtils.cleanDirectBuffer(buf);
+                allocator.close();
             }
         }
 
@@ -293,7 +294,8 @@ private int writeEncryptedData(final ByteBuffer src) {
                 return netWrote;
             }
         } else {
-            ByteBuffer buf = ByteBuffer.allocateDirect(len);
+            final ByteBufferAllocator allocator = getByteBufferAllocator();
+            final ByteBuffer buf = allocator.allocate(len);
             try {
                 final long addr = memoryAddress(buf);
 
@@ -307,8 +309,7 @@ private int writeEncryptedData(final ByteBuffer src) {
                     src.position(pos);
                 }
             } finally {
-                buf.clear();
-                ByteBufferUtils.cleanDirectBuffer(buf);
+                allocator.close();
             }
         }
 
@@ -344,7 +345,8 @@ private int readPlaintextData(final ByteBuffer dst) throws SSLException {
             final int pos = dst.position();
             final int limit = dst.limit();
             final int len = Math.min(MAX_ENCRYPTED_PACKET_LENGTH, limit - pos);
-            final ByteBuffer buf = ByteBuffer.allocateDirect(len);
+            final ByteBufferAllocator allocator = getByteBufferAllocator();
+            final ByteBuffer buf = allocator.allocate(len);
             try {
                 final long addr = memoryAddress(buf);
 
@@ -368,8 +370,7 @@ private int readPlaintextData(final ByteBuffer dst) throws SSLException {
                     }
                 }
             } finally {
-                buf.clear();
-                ByteBufferUtils.cleanDirectBuffer(buf);
+                allocator.close();
             }
         }
 
@@ -389,7 +390,8 @@ private int readEncryptedData(final ByteBuffer dst, final int pending) {
                 return bioRead;
             }
         } else {
-            final ByteBuffer buf = ByteBuffer.allocateDirect(pending);
+            final ByteBufferAllocator allocator = getByteBufferAllocator();
+            final ByteBuffer buf = allocator.allocate(pending);
             try {
                 final long addr = memoryAddress(buf);
 
@@ -403,8 +405,7 @@ private int readEncryptedData(final ByteBuffer dst, final int pending) {
                     return bioRead;
                 }
             } finally {
-                buf.clear();
-                ByteBufferUtils.cleanDirectBuffer(buf);
+                allocator.close();
             }
         }
 
@@ -1606,4 +1607,47 @@ private Set<String> getSupportedProtocolsSet() {
         }
     }
 
+    private interface ByteBufferAllocator {
+        ByteBuffer allocate(final int length);
+
+        void close();
+    }
+
+    private ByteBufferAllocator getByteBufferAllocator() {
+        if (USE_POOLED_BYTEBUFFER) {
+            return new ByteBufferAllocator() {
+                final DefaultByteBufferPool.PooledByteBuffer pooledByteBuffer = DefaultByteBufferPool.DIRECT_POOL.allocate();
+
+                @Override
+                public ByteBuffer allocate(int length) {
+                    ByteBuffer buf = pooledByteBuffer.getBuffer();
+                    buf.limit(length);
+                    return buf;
+                }
+
+                @Override
+                public void close() {
+                    pooledByteBuffer.close();
+                }
+            };
+        } else {
+            return new ByteBufferAllocator() {
+                ByteBuffer buf;
+
+                @Override
+                public ByteBuffer allocate(int length) {
+                    buf = ByteBuffer.allocateDirect(length);
+                    return buf;
+                }
+
+                @Override
+                public void close() {
+                    if (buf != null) {
+                        buf.clear();
+                        ByteBufferUtils.cleanDirectBuffer(buf);
+                    }
+                }
+            };
+        }
+    }
 }