Calibration files & Minor code changes#11
Open
hmchung wants to merge 1 commit intowilldzeng:masterfrom
Open
Conversation
* Modify code to use ini (instead of yaml) calibration file (.ini files are printed directly from the calibration scripts) * Note: ** stere matching seems to work well only at VGA resolution
willdzeng
requested changes
Apr 9, 2018
Owner
willdzeng
left a comment
willdzeng
left a comment
There was a problem hiding this comment.
Thank you just a few comments.
| camera_info_manager::CameraInfoManager info_manager(nh); | ||
| info_manager.setCameraName("zed/left"); | ||
| info_manager.loadCameraInfo( "package://zed_cpu_ros/config/left.yaml"); | ||
| info_manager.loadCameraInfo( "package://zed_cpu_ros/config/" + std::to_string(resolution_) + "/left.ini"); |
Owner
There was a problem hiding this comment.
can you change these two configs into an input param as a string?
different cameras might will have different calibration parameters,
so really make this as a param make more sense.
These two calibration is just an example of what people should be expecting.
Eventually they will have to do a calibration.
| <param name="show_image" value="false"/> | ||
| <param name="left_frame_id" value="left_frame"/> | ||
| <param name="right_frame_id" value="right_frame"/> | ||
| <param name="load_zed_config" value="true"/> |
Owner
There was a problem hiding this comment.
please don't remove load_zed_config option.
| <arg name="config_file_location" default="$(find zed_cpu_ros)/config/SN1267.conf"/> | ||
| <arg name="camera_namespace" default="camera"/> | ||
| <arg name="device_id" default="0"/> | ||
| <arg name="device_id" default="1"/> |
Owner
There was a problem hiding this comment.
I don't think changes on these two default param is necessary.
| cmake_minimum_required(VERSION 2.8.3) | ||
| project(zed_cpu_ros) | ||
|
|
||
| set(CMAKE_CXX_FLAGS "-std=c++11 ${CMAKE_CXX_FLAGS}") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add calibration files for various resolution configurations
Modify code to use ini (instead of yaml) calibration file
(.ini files are printed directly from the calibration scripts)
Note:
** stere matching seems to work well only at VGA resolution