Fix broken gcov invocation in make tests#129
Open
timblaktu wants to merge 1 commit into
Open
Conversation
The tests target compiled all sources in a single gcc call, so .gcno files were named with the output binary prefix and gcov couldn't find them. Use per-file object compilation (via OBJECTS) consistent with the static/shared targets, and pass -o src to gcov so it finds the notes files. Also update GCOV_OUTPUT to clean src/*.gc* files. Fixes willemt#128
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tests target compiled all sources in a single gcc call, so .gcno files were named with the output binary prefix and gcov couldn't find them. Use per-file object compilation (via OBJECTS) consistent with the static/shared targets, and pass -o src to gcov so it finds the notes files. Also update GCOV_OUTPUT to clean src/.gc files.
Fixes #128