feat: revamp elicitation forms for free-text input - #30
Merged
Conversation
single feedback field for ExitPlanMode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reworks the elicitation form rendering so users can enter custom free-text
answers alongside the model-suggested dropdown, instead of being restricted
to enum-only options.
Problem
ACP/MCP elicitation string fields are EITHER an enum (restricted dropdown) OR
free text — the spec forbids a single field that is both. The previous
rendering used a plain
enumfor each question, so users could only pickfrom the model's suggestions with no way to type their own answer.
Changes
AskUserQuestion — dual-field rendering
Each question becomes two fields:
q_<i>: enum dropdown (nowoneOf/anyOfwith {const, title}) + atrailing "Skip this question" option (sentinel
__skip__).q_<i>_other: free-text companion. Non-empty value overrides the dropdown(single-select) or is appended to the picks (multi-select, deduped).
No field is required; blank = skip just that question.
ExitPlanMode — single feedback field
Replaced approve/reject enum with one
feedbacktext field:Docs & tests