refactor: simplify turn preemption by waiting on backend completion - #34
Merged
Conversation
events - Remove `waitForTurnIdle` probing (session/goal) from prompt and preempt paths - Turn loop now sends stop once, then polls until backend emits turn.completed/turn.failed - `pendingTurns` cleanup becomes the reliable "backend done" signal for preempt wait - Reduce subscribe retry attempts (3→2), backoff (1s/2s→0.5s/1s), timeout (10s→5s) - Add `stopSent` flag to `PendingTurn` to prevent duplicate stop calls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
waitForTurnIdleprobing (session/goal) from prompt andpreempt paths
turn.completed/turn.failed
pendingTurnscleanup becomes the reliable "backend done" signal forpreempt wait
timeout (10s→5s)
stopSentflag toPendingTurnto prevent duplicate stop calls