fix: lesson-flow tests for stream-driven practice#116
Merged
Conversation
The lesson-flow component now uses `nextProblemHint` from the backend to drive practice progression instead of iterating a pre-computed list. The frontend test mocks were returning responses without the hint, causing the component to fall back to legacy behavior where `currentProblemId=null` was ambiguous between "initial state" and "practice complete". Adds a `kpPracticeDone` state flag to distinguish these cases and updates test mocks to return `nextProblemHint` matching the real API contract. The stream-driven flow advances directly from one KP to the next without an intermediate "Practice complete" screen for mid-lesson KPs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kpPracticeDonestate flag tolesson-flow.tsxto distinguish "no problem selected yet" from "all KPs passed" (both previously resulted incurrentProblemId === null)nextProblemHintin API responses, matching the real stream-driven contract from the wrong-answer remediation loopTest plan
🤖 Generated with Claude Code