fix(mcp): serve widget JS externally (ChatGPT sandbox) - #137
Merged
Conversation
ChatGPT's widget sandbox appears to block our inline <script> (nothing in it runs — not even a diagnostic). Move the widget JS out of app.html into app.js, served publicly at GET /mcp-widget.js from the API origin, and load it via <script src>. Add the API origin (PublicBaseURL) to the widget CSP resourceDomains so the sandbox allows it. Also changes the static loading text to 'Setting the table…' as a tell-tale to confirm ChatGPT fetches the fresh widget (vs serving a cached copy). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
windoze95
added a commit
that referenced
this pull request
Jul 8, 2026
…back (#138) ChatGPT's widget sandbox won't execute our widget's script (inline or external), so the externalization (#137) didn't help and risked regressing the Claude widget, which renders fine. This reverts the externalization (back to the inline script + drops /mcp-widget.js, app.js, and the CSP/route changes) to protect Claude. - Replace the perpetual 'Warming up the kitchen…' loading note with a graceful branded static fallback (Sb · SaltyBytes), so ChatGPT (where the script can't run and the tools narrate the recipe in text) shows a clean card, not a stuck spinner. - Remove the temporary debug diagnostic; keep a clean window.openai delivery-poll as groundwork for a future ChatGPT Apps-SDK build. Tools work in both hosts; the interactive widget renders in Claude. ChatGPT = tools-first. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempt to make the widget render in ChatGPT. Evidence points to ChatGPT's sandbox blocking our inline
<script>(nothing in it executes). This moves the JS to/mcp-widget.js(served from the API, allow-listed in the widget CSP) and loads it via<script src>; also changes the loading text to 'Setting the table…' as a cache tell-tale. Tests updated; build/vet/test pass.🤖 Generated with Claude Code