fix(pad-levels): guard against undefined padding for unknown levels - #350
Merged
Merged
Conversation
Contributor
Author
|
\ud83d\udd27 Auto-fix: Rebased onto latest to resolve the TypeScript 6.0 deprecation CI failure. |
mixelburg
force-pushed
the
fix/pad-levels-unknown-level
branch
from
June 13, 2026 00:15
865151a to
4870971
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a logger uses custom levels (e.g. `config.syslog.levels`) but the `padLevels` format is initialized with a different level set, `this.paddings[info[LEVEL]]` is `undefined`. This gets coerced to the string `"undefined"` and prepended to every log message.
Defensive fix: default to `""` when a level is missing from the padding map.
Fixes the behavior reported in winstonjs/winston#2477 where using `format.cli()` with syslog levels produces output like
emerg:undefinedHello World!.