Skip to content

[winston #1606]: stringify info.message in simple formatter - #88

Open
DABH wants to merge 1 commit into
masterfrom
winston-1606
Open

[winston #1606]: stringify info.message in simple formatter#88
DABH wants to merge 1 commit into
masterfrom
winston-1606

Conversation

@DABH

@DABH DABH commented Mar 24, 2019

Copy link
Copy Markdown
Contributor

"Fixes" cases such as the one here where users want simple to stringify objects. Fair enough, "simple" sounds like it should "just work" even if jsonStringify is an extra performance hit.

winstonjs/winston#1606

@DABH

DABH commented Mar 24, 2019

Copy link
Copy Markdown
Contributor Author

@indexzero this causes info.message to get quotes around it if it's a string, e.g.
'info: "whatever"' instead of 'info: whatever'
do you reckon that's ok? jsonStringify and util.inspect both do that, not sure if one can get around it without explicit typecheck/case for String.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant