Skip to content

Remove obsolete secrets from the brig config #874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sghosh23 merged 3 commits into from
Mar 3, 2026
Merged

Remove obsolete secrets from the brig config #874

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dc9d0af
Remove obsolete secrets from the brig config
sghosh23 Feb 27, 2026
2251308
add the changelog
sghosh23 Feb 27, 2026
44ce29e
add the important line
sghosh23 Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions bin/offline-secrets.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,12 +53,7 @@ brig:
password: guest
# These are only necessary if you wish to support sign up via SMS/calls
# And require accounts at twilio.com / nexmo.com
setTwilio: |-
sid: "dummy"
token: "dummy"
setNexmo: |-
key: "dummy"
secret: "dummy"

cargohold:
secrets:
awsKeyId: "$minio_cargohold_access_key"
Expand Down
9 changes: 1 addition & 8 deletions bin/secrets.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,14 +104,7 @@ brig:
# these only need to be changed if using real AWS services
awsKeyId: dummykey
awsSecretKey: dummysecret
# These are only necessary if you wish to support sign up via SMS/calls
# And require accounts at twilio.com / nexmo.com
setTwilio: |-
sid: dummy
token: dummy
setNexmo: |-
key: dummy
secret: dummy

cargohold:
secrets:
awsKeyId: dummykey
Expand Down
1 change: 1 addition & 0 deletions changelog.d/3-deploy-builds/remove-oboslete-secrets
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Removed: obsolete secrets from scripts and references for improved security and clarity.
6 changes: 0 additions & 6 deletions values/wire-server/demo-secrets.example.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,6 @@ brig:
# To extract the secret from an existing Kubernetes cluster:
# kubectl get secret wire-postgresql-secret -n postgresql -o jsonpath='{.data.password}' | base64 -d
pgPassword: dummyPassword # gets replaced by the actual secret
setTwilio: |-
sid: "dummy"
token: "dummy"
setNexmo: |-
key: "dummy"
secret: "dummy"
elasticsearch:
username: "elastic"
password: "changeme"
Expand Down
6 changes: 0 additions & 6 deletions values/wire-server/prod-secrets.example.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,6 @@ brig:
rabbitmq:
username: guest
password: guest
setTwilio: |-
sid: "dummy"
token: "dummy"
setNexmo: |-
key: "dummy"
secret: "dummy"

cannon:
secrets:
Expand Down