Conversation
lwille
left a comment
lwille
left a comment
There was a problem hiding this comment.
Approve as this will fix my issue, but left some thoughts to consider :)
.envrc
Outdated
| echo " If you don't want to use it, run the following command to unset it" | ||
| echo " git config --unset core.hooksPath" |
There was a problem hiding this comment.
thought: this will be overwritten by the next direnv run, so I'd rather output a hint about how to skip commit validation if you really need to, e.g.
| echo " If you don't want to use it, run the following command to unset it" | |
| echo " git config --unset core.hooksPath" | |
| echo "To skip commit validation via git hooks, use `git commit --no-verify ...`. |
| Git Hooks has been configured in your current environment. | ||
| Read more about them here: https://github.com/wireapp/wire-server-deploy?tab=readme-ov-file#optional-git-commit-message-verification | ||
| If you don't want to use it, run the following command to unset it | ||
| git config --unset core.hooksPath |
There was a problem hiding this comment.
note: it's not really true, since the next direnv run will activate the hooks again.
suggestion: If you want people to be able to opt out of git hooks altogether, you could invent something like a NO_GIT_HOOKS env var that one could put into .envrc.local (which is evaluated prior to setting up the hooks).
Bear in mind I don't really understand your workflow and why being able to opt out of githooks is such a big deal - but in case validation breaks, people can always use --no-verify when committing.
Personally, I'm always happy if projects provide validation hooks, so I'd not even make a fuzz about disabling it 😅
|
2 participants
Change type
Basic information
Testing
Offline Build CI (label-based)
Add one or more labels to trigger offline builds:
build-default- Full production build (ansible, terraform, all packages)build-demo- Demo/WIAB buildbuild-wiab-staging- WIAB-staging buildbuild-min- Minimal build (fastest, essential charts only)build-all- Run all three buildsNote: No builds run by default. Add a label to trigger CI.
Tracking
changelog.dKnowledge Transfer
Motivation
Objective
Reason
Use case