Skip to content

Conversation

@sgdevnet
Copy link
Collaborator

No description provided.

@sgdevnet sgdevnet requested a review from wisedev-pstach July 24, 2025 19:06
Copy link
Contributor

@wisedev-pstach wisedev-pstach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Defo step in good direction, Can you double check other projects? I am sure that there are more opportunities to add good error handling, I think good candidate can be InferPage project (its the one that opens with mcli "infer" command)

And also Core project, Its mainly "projection" layer but it also lacks good error handling atm, For example, i think now it will even allow to create ChatContext without providing model, which does not make sense at all, similar perhaps for AgentContext

@sgdevnet
Copy link
Collaborator Author

Looks good! Defo step in good direction, Can you double check other projects? I am sure that there are more opportunities to add good error handling, I think good candidate can be InferPage project (its the one that opens with mcli "infer" command)

And also Core project, Its mainly "projection" layer but it also lacks good error handling atm, For example, i think now it will even allow to create ChatContext without providing model, which does not make sense at all, similar perhaps for AgentContext

Dear Mr. Reviewer,

  • created more custom exceptions,
  • added exception handling in the Examples project (error section in console with error message when an exception is thrown),
  • added exception handling in the InferPage project (red error message component slides out from the upper right corner if an exception is thrown),
  • improved handling of errors returned by open ai and anthropic api - now we have more concrete error messages
  • added interfaces to ChatContext and AgentContext which allow you to validate and better control fluent API operations,
  • added XML Documentation Comments to method signatures in the interfaces for each conexts. It may be helpful for people using the framework and can be used by IntelliSense,
  • performed cleanup regarding usings and namespaces (this has increased the number of changed files - I hope you won't be scared by it xD)

@sgdevnet sgdevnet changed the title Feat: Add custom exceptions [#19] Feat: [#19] Add custom exceptions, improve error handling Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants